Add setNodeNetworkUnavailable option for calico node #9479
Conversation
marvin-tigera
added
release-note-required
|
|
yuzhiquan
force-pushed
the
yzq/add-option-set-node-status
branch
from
c1331e8
to
434bc9b
Compare
Out of curiosity, could you provide a bit more context for this? Is it Calico that is unable to accept requests or something else in the network? How do you plan to configure this CLI flag - I don't think there's a way currently to set this when installing e.g., via the operator? |
We believe the root cause is the number of our nodes has achieved the quota of full-mesh mode, so we have plan to enable RR in the future, this pr just wants to give another choice in this condition, we can mark the node as ready when we make sure the network is ready for receive requests.
Sorry, I'm not familiar with this part. Do you have any suggestions? |
Yeah, it would need to be plumbed through the operator code here: https://github.com/tigera/operator/blob/master/pkg/render/node.go#L1280-L1310 Likely by introducing a a new API field to the e.g., It would likely need to be passed through via an environment variable rather than a CLI flag (since the calico/node container configures each process using env vars typically). I think it's probably OK to add this as an option.. although I think it's just working around the real problem(s):
|
Description
New feature, add an option
setNodeNetworkUnavailable, default is true, control the behavior after calico-node is readyand the calico node to set
NodeNetworkUnavailable = falseor not.Some times, in our cluster, we have noticed that the node is ready and
NodeNetworkUnavailable = false. but our network is not ready to accept the requests, so we want to add this option to control this.And we also can find the options in other network projects like flannel or cilium.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.